file_context_dtor in file.c

php.internals

Stanislav Malyshev

23 years ago
Could someone who knows the new streams code look explain me what the code in file.c in ZEND_RSRC_DTOR_FUNC(file_context_dtor) supposed to do? It was destroying context->options twice - once with zval_dtor(context->options) directly (which I have commented out) and once from php_stream_context_free(context). What was it meant to do?
-- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.109

Stanislav Malyshev

23 years ago
Oh, I had older version of the file, so now it looks OK. SM>> Could someone who knows the new streams code look explain me what the code SM>> in file.c in ZEND_RSRC_DTOR_FUNC(file_context_dtor) supposed to do? It was SM>> destroying context->options twice - once with zval_dtor(context->options) SM>> directly (which I have commented out) and once from SM>> php_stream_context_free(context). What was it meant to do? SM>> SM>>
-- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.109

(Marcus Börger)

23 years ago
Hello Stanislav, that is something i 'hopefully' fixed for the moment but i think sara did it wrong. So i'll ask here when she's back on irc. Sunday, June 15, 2003, 5:51:17 PM, you wrote: SM> Oh, I had older version of the file, so now it looks OK. SM>>> Could someone who knows the new streams code look explain me what the code SM>>> in file.c in ZEND_RSRC_DTOR_FUNC(file_context_dtor) supposed to do? It was SM>>> destroying context->options twice - once with zval_dtor(context->options) SM>>> directly (which I have commented out) and once from SM>>> php_stream_context_free(context). What was it meant to do? SM>>> SM>>> SM> -- SM> Stanislav Malyshev, Zend Products Engineer SM> stas@zend.com http://www.zend.com/ +972-3-6139665 ext.109
-- Best regards, Marcus mailto:helly@php.net

Stanislav Malyshev

23 years ago
MB>> that is something i 'hopefully' fixed for the moment but i think sara MB>> did it wrong. So i'll ask here when she's back on irc. There's still some leaks BTW with this fix, but I didn't research them yet. Anyway, leaks are better than crash :)
-- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.109