Win32 developers

php.internals

Sascha Schumann

23 years ago
Win32 folks, the ze2 is now always checked out into a ZendEngine2 directory. It appears to me that this one line diff might be sufficient already: --- php5ts.dsw 23 Jun 2003 04:27:11 -0000 1.18 +++ php5ts.dsw 25 Jun 2003 13:07:36 -0000 @@ -15,7 +15,7 @@ ############################################################################### -Project: "ZendTS"="..\Zend\ZendTS.dsp" - Package Owner=<4> +Project: "ZendTS"="..\ZendEngine2\ZendTS.dsp" - Package Owner=<4> Package=<5> {{{ - Sascha ---------- Forwarded message ---------- Date: Wed, 25 Jun 2003 13:02:48 -0000 From: Sascha Schumann <sas@php.net> To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: CVSROOT / modules sas Wed Jun 25 09:02:48 2003 EDT Modified files: /CVSROOT modules Log: checkout ze1 and ze2 with php-src Index: CVSROOT/modules diff -u CVSROOT/modules:1.54 CVSROOT/modules:1.55 --- CVSROOT/modules:1.54 Wed Jun 25 08:46:41 2003 +++ CVSROOT/modules Wed Jun 25 09:02:48 2003 @@ -1,7 +1,7 @@ # # The CVS Modules File # -#ident "@(#)cvs/examples:$Name: $:$Id: modules,v 1.54 2003/06/25 12:46:41 zeev Exp $" +#ident "@(#)cvs/examples:$Name: $:$Id: modules,v 1.55 2003/06/25 13:02:48 sas Exp $" # # Three different line formats are valid: # key -a aliases... @@ -35,13 +35,12 @@ ze2-dir -d Zend ZendEngine2 # what it should become: -#php-src php-src &TSRM &Zend &ZendEngine2 -#php-src-ze1 -a php-src -#php-src-ze2 -a php-s +php-src php-src &TSRM &Zend &ZendEngine2 +php-src-ze1 -a php-src +php-src-ze2 -a php-src -php-src-ze1 -d php-src php-src &TSRM &Zend -php-src-ze2 -d php-src php-src &TSRM &ze2-dir -php5 -d php5 php-src &TSRM &ze2-dir +#php-src-ze1 -d php-src php-src &TSRM &Zend +#php-src-ze2 -d php-src php-src &TSRM &ze2-dir phpweb phpweb pear pear
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Edin Kadribasic

23 years ago
Its not that simple. There is a need to specify Zend dir in the include path in all ext/*.dsp files. I think we should go back to having always Zend directory which makes life for people compiling PHP on Windows easier. Edin ----- Original Message ----- From: "Sascha Schumann" <sascha@schumann.cx> To: <internals@lists.php.net> Sent: Wednesday, June 25, 2003 3:08 PM Subject: [PHP-DEV] Win32 developers Win32 folks, the ze2 is now always checked out into a ZendEngine2 directory. It appears to me that this one line diff might be sufficient already: --- php5ts.dsw 23 Jun 2003 04:27:11 -0000 1.18 +++ php5ts.dsw 25 Jun 2003 13:07:36 -0000 @@ -15,7 +15,7 @@ #################################################################### ########### -Project: "ZendTS"="..\Zend\ZendTS.dsp" - Package Owner=<4> +Project: "ZendTS"="..\ZendEngine2\ZendTS.dsp" - Package Owner=<4> Package=<5> {{{ - Sascha ---------- Forwarded message ---------- Date: Wed, 25 Jun 2003 13:02:48 -0000 From: Sascha Schumann <sas@php.net> To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: CVSROOT / modules sas Wed Jun 25 09:02:48 2003 EDT Modified files: /CVSROOT modules Log: checkout ze1 and ze2 with php-src Index: CVSROOT/modules diff -u CVSROOT/modules:1.54 CVSROOT/modules:1.55 --- CVSROOT/modules:1.54 Wed Jun 25 08:46:41 2003 +++ CVSROOT/modules Wed Jun 25 09:02:48 2003 @@ -1,7 +1,7 @@ # # The CVS Modules File # -#ident "@(#)cvs/examples:$Name: $:$Id: modules,v 1.54 2003/06/25 12:46:41 zeev Exp $" +#ident "@(#)cvs/examples:$Name: $:$Id: modules,v 1.55 2003/06/25 13:02:48 sas Exp $" # # Three different line formats are valid: # key -a aliases... @@ -35,13 +35,12 @@ ze2-dir -d Zend ZendEngine2 # what it should become: -#php-src php-src &TSRM &Zend &ZendEngine2 -#php-src-ze1 -a php-src -#php-src-ze2 -a php-s +php-src php-src &TSRM &Zend &ZendEngine2 +php-src-ze1 -a php-src +php-src-ze2 -a php-src -php-src-ze1 -d php-src php-src &TSRM &Zend -php-src-ze2 -d php-src php-src &TSRM &ze2-dir -php5 -d php5 php-src &TSRM &ze2-dir +#php-src-ze1 -d php-src php-src &TSRM &Zend +#php-src-ze2 -d php-src php-src &TSRM &ze2-dir phpweb phpweb pear pear
-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Sascha Schumann

23 years ago
On Wed, 25 Jun 2003, Edin Kadribasic wrote:
> Its not that simple. There is a need to specify Zend dir in the > include path in all ext/*.dsp files.
Ok, then you probably should do something similar to the buildconf trick, i.e. rename the directories according to the currently active PHP version.
> I think we should go back to > having always Zend directory which makes life for people compiling > PHP on Windows easier.
That would be a literal step backwards. Streamlining CVS handling is something which the project had a long-standing need for. - Sascha

Edin Kadribasic

23 years ago
On Wed, 25 Jun 2003, Sascha Schumann wrote:
> > I think we should go back to > > having always Zend directory which makes life for people compiling > > PHP on Windows easier. > > That would be a literal step backwards. Streamlining CVS > handling is something which the project had a long-standing > need for.
There is no buildconf on Windows. So this CVS streamlining would mean additional manual steps between checkout and compile, updates to the build documentation, etc. More pain than gain IMHO. Edin

Zeev Suraski

23 years ago
At 16:41 25/06/2003, Edin Kadribasic wrote:
>On Wed, 25 Jun 2003, Sascha Schumann wrote: > > > > I think we should go back to > > > having always Zend directory which makes life for people compiling > > > PHP on Windows easier. > > > > That would be a literal step backwards. Streamlining CVS > > handling is something which the project had a long-standing > > need for. > >There is no buildconf on Windows. So this CVS streamlining would mean >additional manual steps between checkout and compile, updates to the build >documentation, etc. > >More pain than gain IMHO.
I agree. The whole CVS move was mostly to make things more correct, with fairly small tangible gains. I'm fine with it, as long as it doesn't complicate our lives. We should keep the php5 module, and it should check out ZendEngine2 as Zend. Zeev

Sebastian Bergmann

23 years ago
Zeev Suraski wrote:
> We should keep the php5 module, and it should check out ZendEngine2 as > Zend.
I take it that - Move HEAD of Zend/ into a PHP_4 tag. - Commit HEAD of ZendEngine2/ to HEAD of Zend/. - Delete ZendEngine2/. is not possible / feasible?
-- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ http://www.professionelle-softwareentwicklung-mit-php5.de/

Zeev Suraski

23 years ago
At 16:54 25/06/2003, Sebastian Bergmann wrote:
>Zeev Suraski wrote: > > We should keep the php5 module, and it should check out ZendEngine2 as > > Zend. > > I take it that > > - Move HEAD of Zend/ into a PHP_4 tag. > > - Commit HEAD of ZendEngine2/ to HEAD of Zend/. > > - Delete ZendEngine2/. > > is not possible / feasible?
It means losing history - not an option. Zeev

Sebastian Bergmann

23 years ago
Zeev Suraski wrote:
> It means losing history - not an option.
Ah, I meant without losing history.
-- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ http://www.professionelle-softwareentwicklung-mit-php5.de/